Sopuli
  • Communities
  • Create Post
  • Create Community
  • heart
    Support Lemmy
  • search
    Search
  • Login
  • Sign Up
Peter_Arbeitslos@discuss.tchncs.de to Programmer Humor@lemmy.mlEnglish ·
edit-2
1 year ago

Real find in a website's javascript

discuss.tchncs.de

message-square
17
link
fedilink
300

Real find in a website's javascript

discuss.tchncs.de

Peter_Arbeitslos@discuss.tchncs.de to Programmer Humor@lemmy.mlEnglish ·
edit-2
1 year ago
message-square
17
link
fedilink
alert-triangle
You must log in or # to comment.
  • tills13@lemmy.world
    link
    fedilink
    arrow-up
    48
    ·
    1 year ago

    It’s an internal inside of React.

    • FooBarrington@lemmy.world
      link
      fedilink
      arrow-up
      35
      ·
      1 year ago

      https://github.com/facebook/prop-types/blob/4de0644a10a554d0a556daa39f029369bc007ea5/lib%2FReactPropTypesSecret.js#L10

      Crazy what other commenters are coming up with.

    • neclimdul@lemmy.world
      link
      fedilink
      arrow-up
      6
      arrow-down
      1
      ·
      1 year ago

      So using react will get you fired? I knew it!

  • xmunk@sh.itjust.works
    link
    fedilink
    arrow-up
    50
    arrow-down
    4
    ·
    1 year ago

    What an absolutely shitty peppering string.

    • Peter_Arbeitslos@discuss.tchncs.deOP
      link
      fedilink
      English
      arrow-up
      62
      arrow-down
      4
      ·
      1 year ago

      The code file has 32.171 lines, at least after beautifing it. 1MB fucking js code.

      • unalivejoy@lemm.ee
        link
        fedilink
        English
        arrow-up
        5
        ·
        1 year ago

        Don’t worry, this file is likely the output of a bundler.

  • morrowind@lemmy.ml
    link
    fedilink
    arrow-up
    24
    ·
    1 year ago

    What am I looking at here?

    • ImplyingImplications@lemmy.ca
      link
      fedilink
      arrow-up
      61
      arrow-down
      5
      ·
      1 year ago

      There’s a string stating that the code should not be passed or the employee will be fired. I’d assume this was a test to see if an employee meant to be doing code review was actually doing them. Spoiler, they were not, as OP said they found this in production code.

      • xmunk@sh.itjust.works
        link
        fedilink
        arrow-up
        17
        arrow-down
        4
        ·
        1 year ago

        I’d go a step further and I suspect it’s a peppering string (i.e. fixed string you add to hashes to defeat rainbow tables). I’d really hope it isn’t as you mentioned because gosh that sounds like a toxic workplace if someone is just leaving landmines around purely to get someone fired.

        • skulblaka@startrek.website
          link
          fedilink
          arrow-up
          20
          arrow-down
          1
          ·
          1 year ago

          More like, you know damn well that Jim keeps passing code reviews without reading a line in them, he’s been talked to, still does it, and you need something actionable to prove it so that you can get someone’s ass in his chair who does their job.

          • jcg@halubilo.social
            link
            fedilink
            arrow-up
            12
            ·
            1 year ago

            From the stories I’ve heard from corporate software employees, this does sound like exactly the kind of thing you gotta do to show some manager the guy is buddy-buddy with that they’re actually not doing their job. And even then they didn’t listen.

        • Reddfugee42@lemmy.world
          link
          fedilink
          arrow-up
          1
          arrow-down
          2
          ·
          edit-2
          1 year ago

          Would that imply that all quality control is evil?

          • xmunk@sh.itjust.works
            link
            fedilink
            arrow-up
            3
            arrow-down
            2
            ·
            1 year ago

            No, I don’t think so - it’s just a dick move to go out of your way to sabotage someone. If they’re fucking up just visit their existing mistakes - don’t waste time contriving new ones.

            • Reddfugee42@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              1 year ago

              So when TSA sends fake guns and bombs through luggage, it’s not qa, it’s just a dick move to sabotage them?

  • AdamEatsAss@lemmy.world
    link
    fedilink
    arrow-up
    16
    arrow-down
    2
    ·
    1 year ago

    I bet the guy who said “looks good to me” still has a job too.

  • winterayars@sh.itjust.works
    link
    fedilink
    arrow-up
    13
    arrow-down
    1
    ·
    1 year ago

    You should really be using a pre commit hook to catch secrets. Admittedly it may not have caught this, but manual review is (clearly) not always sufficient.

  • dean [any pronouns]@beehaw.org
    link
    fedilink
    English
    arrow-up
    11
    ·
    1 year ago

    it’s part of react proptypes: https://github.com/facebook/prop-types/blob/4de0644a10a554d0a556daa39f029369bc007ea5/lib/ReactPropTypesSecret.js#L10

Programmer Humor@lemmy.ml

programmerhumor@lemmy.ml

Subscribe from Remote Instance

Create a post
You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !programmerhumor@lemmy.ml

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

  • Posts must be relevant to programming, programmers, or computer science.
  • No NSFW content.
  • Jokes must be in good taste. No hate speech, bigotry, etc.
Visibility: Public
globe

This community can be federated to other instances and be posted/commented in by their users.

  • 208 users / day
  • 786 users / week
  • 2.68K users / month
  • 8.8K users / 6 months
  • 453 local subscribers
  • 37K subscribers
  • 1.57K Posts
  • 34.4K Comments
  • Modlog
  • mods:
  • AgreeableLandscape@lemmy.ml
  • cat_programmer@lemmy.ml
  • BE: 0.19.12
  • Modlog
  • Legal
  • Instances
  • Docs
  • Code
  • join-lemmy.org