[issue]: Remove BLOBs from the source tree · Issue #2795 · ventoy/Ventoy
github.com
What happened? Due to the recent XZ-Utils drama I checked the code and I'm appalled. There are more BLOBS than source code. https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f8946...

I had no idea this issue had been identified. While I find this tool very useful, the project is seeming rather questionable to me now.

  • bleistift2English
    10·
    2 months ago

    I cannot fathom what in this issue description gives rise to your concern. It’s worded very calmly, clearly explaining why the author thinks these BLOBs shouldn’t be there, expressing an understanding that it’s not a top priority and even closing with a thank you.

    • ⸻ Ban DHMO 🇦🇺 ⸻@aussie.zoneEnglish
      12·
      2 months ago

      Is this not rude:

      I checked the code and I’m appalled. There are more BLOBs than source code

      And this:

      I understand that removing BLOBs isn’t a priority over new and shiny features. But due to recent events, this should be rethought.

      We didn’t like it when MS made an issue trying to direct ffmpeg

      They should have opened with a complement or asked for directions if they didn’t know. In this message “Thank You” means fuck all

      • bleistift2English
        1·
        2 months ago

        Is this not rude:

        I checked the code and I’m appalled. There are more BLOBs than source code

        No. The commenter is voicing their own feelings and explains why they have them. There is neither blaming nor rudeness here.

        And this:

        I understand that removing BLOBs isn’t a priority over new and shiny features. But due to recent events, this should be rethought.

        It would have been nice if you had explained why you think this is rude. The author expresses understanding that the maintainers’ priorities don’t align with the author’s. This seems to be an uncontroversial statement to me.

        Then the author explains (I agree, it’s more a hint than an explanation) why they think the priorities should be changed. In my view their argument is sound. Again, there is no blaming or rudeness here.

        They should have opened with a complement

        I assume you mean “compliment”.

        I’ve often heard of the “sandwich technique” – start with a compliment, then voice criticism, end with another positive thing. I find this is an appropriate procedure when voicing open feedback, that is, good things and bad things. However, this is a Github issue. Its whole point is to point out a perceived problem, not to give the maintainers a pat on the back or thank them.

        • ⸻ Ban DHMO 🇦🇺 ⸻@aussie.zoneEnglish
          12·
          2 months ago

          I don’t understand how “appalled” being strong language is so controversial, maybe everyone here is just a rude little shit.

          I would have worded it like so:

          Hi, I’m concerned about the BLOBs used in this repo as they are a security risk, making the code less auditable. It looks like we could generate these BLOBs in a github action or something so we can keep the fast build process while making it easier to audit the code. I’m not exactly sure how to go about this myself but I’ve done similar things in other projects, maybe you could point me in the right direction as I am unfamiliar with the ventoy build process? Thanks for the really cool project, and hopefully we can sort this out easily. Looking forward to your response.

          I did it with less anger and entitlement and in less words