I try to limit the amount of personal data being shared, so I really like the Hello Weather app for their privacy policy (although a lot of their features are behind a paywall).

Other than that, I use Apple Weather since I figure Apple already has my data anyway ¯\_(ツ)_/¯