I have done plenty of basic scripting for work, but this is my first “real” project, and wanted to see what real python experts think of it and see if there is anything I might be doing horribly wrong lol.
Im deploying documentation automatically here: https://ogs-python.dakotamarshall.net/
And the PyPI package is here: https://pypi.org/project/ogsapi/
I am very much a beginner, and its still very much a work in progress. Let me know if there is anything that could be drastically improved!
After a quick skim, I might suggest looking into dataclasses. Particularly that
OGSGameclass might be a good candidate. They can remove a lot of necessary init boilerplate, and you’d getasdictfor free.Just discovered dataclasses the other day actually, Im using it for
OGSCredentialsand am happy with how easy it was, so I will be converting other stuff over to it as well!I would opt for Traitlets over dataclasses… but both are superior to vanilla Python objects.
Ill take a look at Traitlets too! Thanks!
Kind of silly since python is basically source code in wheel form, but you have the package on pypi listed as gpl3 but don’t provide a source repo link.
Also, I write worse code than this and get paid a lot for it :P don’t sell yourself short
I would import whatever functions you want users to use often in the init script of the ogsapi module … But idk python packages are all over the place with stuff like that, it’s definitely not required.
Oh man, you’re right! Whoops. I’ll go ahead and add that, lol.
I appreciate that! Glad im not doing anything horribly wrong… I’ll have to play around with the init script to see how to make it easier to get the needed functions.
I do have a pertinent question I forgot to ask about in my main post if you have some time, though. I am using SocketIO for their realtime API, and needed to figure out how to pass events received from the socket onto the client that is using the wrapper. I opted for requiring callback functions to be registered for the different events we could receive, that way they can choose what functions they want called when we get the event, but is that the best way to do it? I couldn’t think of any other method to pass that event in an async fashion, lol.
I think what you have is the perfect amount of complexity, and easily extendable. I use callbacks like this all the time in my code, but also my users are part of my team at work so they don’t have far for help when the callback API isnt clear :P most of my users dont even know callbacks are a thing.
If your list of supported events gets large or you want to cheaply support future changes to the server, you could pass all event names and data through a handler callback and make users handle multiple event types.
One of the things that makes plain callbacks nice is it’s an easy way to let your users decide how they want to integrate with your library. If your callbacks are called from a background thread, it’s up to the user to figure out how they want to pass the event to other threads. Async users can use their runtime of choice to submit tasks from a callback.
Awesome, thanks for the feedback!
The callbacks not being widely known about was my concern as well, as I had only heard about them when researching a solution for this, lol. I’ll probably stick with my solution, and write a page in the documentation describing what they are and how to use them, to hopefully make it clear.
Really great work for a beginner, everything looks clean and you’re good at documenting!
Thanks! I figure my code can be pretty bad but if my documentation is at least decent people will be able to use it lmao.
oh you stored it on gitlab instead of github… quite unique.
yup! I enjoy their CI stuff more, and its not owned my Microsoft, so thats a plus :)
Plus we use gitlab selfhosted at work, so its just what Im used to.
